fixed the issue #4660 - shouldn't use a hook like function name for a variable #4693
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for a variable!
✅ Deploy Preview for volto canceled.
|
|
@Kaku-g thanks for the contribution, but I don't think it's relevant issue for now. |
|
@sneridagh It was in response to an issue Tiberiu opened -- should we close #4660 as well? |
|
@davisagli Uh, I missed that Tiberiu was asking for it... in that case, let's consider it again. |
sneridagh
requested changes
May 9, 2023
| @@ -110,7 +110,7 @@ const PersistentSlashMenu = ({ editor }) => { | |||
|
|
|||
| const [slashMenuSelected, setSlashMenuSelected] = React.useState(0); | |||
|
|
|||
| const useAllowedBlocks = !isEmpty(allowedBlocks); | |||
| const allowedBlockSection = !isEmpty(allowedBlocks); | |||
There was a problem hiding this comment.
I would use the name hasAllowedBlocks as it's a Boolean.
There was a problem hiding this comment.
Updated the required changes
sneridagh
approved these changes
May 23, 2023
sneridagh
added a commit
that referenced
this pull request
May 24, 2023
…a variable (#4693) Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh
added a commit
that referenced
this pull request
May 26, 2023
* master: Release changelog for 16.20.7 (#4816) Release 17.0.0-alpha.8 Add supported languages (#4811) Fix html tag lang attribute in SSR (#4803) Finnish translation forwardport (#4084) (#4810) Control panel for relations (#3382) Add guard in case of malformed blocks are present (at least id and title should be present) (#4802) fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693) Fix HMR of @plone/volto (#4799)
sneridagh
added a commit
that referenced
this pull request
Jun 8, 2023
* master: (26 commits) Update Brazilian Portuguese translations (Fixes #4853) Convert header class to function (#4767) Use a Container from the registry in the Form component and fallback to the Semantic UI one (#4849) Display password validation error if available; update minimum password length (#4801) Do not break requires validation on number fields with value 0 (#4841) Search Block: Add support for advanced facets that are displayed on demand (#4784) Release 17.0.0-alpha.9 Fix navigation sections in 404 pages (#4836) fix special characters in request urls (#4825) Fix block is undefined in StyleWrapper helper when building classnames (#4827) Fix glossary warning due to lack of empty line before a term (#4820) Release changelog for 16.20.7 (#4816) Release 17.0.0-alpha.8 Add supported languages (#4811) Fix html tag lang attribute in SSR (#4803) Finnish translation forwardport (#4084) (#4810) Control panel for relations (#3382) Add guard in case of malformed blocks are present (at least id and title should be present) (#4802) fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693) Fix HMR of @plone/volto (#4799) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the name of the variable from hook like function name to normal variable name.